fix: resolve all 16 failing tests across 5 utility modules#178
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: fix wordCount for multiple spaces, implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: use Math.round for day calculation in formatRelative - validator: allow long TLDs in isEmail, allow ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dividenow throws on division by zero instead of returning InfinitywordCountto handle multiple consecutive spaces; implementedtruncatewith word-boundary logicremove,update, andsortBymethodsformatRelativeby usingMath.roundfor day calculationisEmailto allow long TLDs (2+ chars); fixedisUrlto allow port numbersTest Results
All 60 tests pass (was 44 pass / 16 fail).
Assumptions
truncatetruncates at word boundaries so the result including "..." fits withinmaxLengthsortBy("priority")sorts high > medium > lowsortBy("createdAt")sorts oldest firstError("Division by zero")