Initialize line_sender_buffer using sender.new_buffer()#390
Open
pmull18 wants to merge 4 commits intoquestdb:mainfrom
Open
Initialize line_sender_buffer using sender.new_buffer()#390pmull18 wants to merge 4 commits intoquestdb:mainfrom
pmull18 wants to merge 4 commits intoquestdb:mainfrom
Conversation
Current documentation assumes the existence of a default constructor, which does not exist. Not a vital change, but took me longer than I care to admit to figure out that's why my project wasn't compiling.
jerrinot
approved these changes
Apr 14, 2026
jerrinot
added a commit
that referenced
this pull request
Apr 14, 2026
Pin gitleaks/gitleaks-action to a full commit SHA (v2.3.9) instead of the mutable v2 tag, so a compromise of the upstream repo or tag can't silently change what runs in CI. Skip the step when GITLEAKS_LICENSE is empty. Pull requests from forks don't receive org secrets, which was causing the check to fail on external contributor PRs (e.g. #390).
jerrinot
added a commit
that referenced
this pull request
Apr 14, 2026
…ng (#419) Pin gitleaks/gitleaks-action to a full commit SHA (v2.3.9) instead of the mutable v2 tag, so a compromise of the upstream repo or tag can't silently change what runs in CI. Skip the step when GITLEAKS_LICENSE is empty. Pull requests from forks don't receive org secrets, which was causing the check to fail on external contributor PRs (e.g. #390).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current documentation assumes the existence of a default constructor for line_sender_buffer, which does not exist. Not a vital change, but took me longer than I care to admit to figure out that's why my project wasn't compiling.