Open
Conversation
Collaborator
|
b287cb1 to
cfae5fd
Compare
Contributor
[PR Coverage check]😍 pass : 26 / 42 (61.90%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaTlsClientSocket.recv()to handle valid TLSBUFFER_OVERFLOWconditions by growing an internal unwrap-output buffer instead of failingrecv()calls and harden the same overflow paths during TLS handshake processingRoot cause
Wide TLS QWP reads could hit
Output buffer too small to fit a single TLS recordbecause decrypted plaintext was written directly into the caller buffer and overflow was treated as impossible.Testing
env JAVA_HOME=/usr/lib/jvm/java-17-openjdk mvn -f java-questdb-client/pom.xml -pl core -Dtest=JavaTlsClientSocketTest test