wayland/window: add WaylandWindow attached object for overriding App ID of wayland toplevels#899
Open
bbedward wants to merge 2 commits into
Open
wayland/window: add WaylandWindow attached object for overriding App ID of wayland toplevels#899bbedward wants to merge 2 commits into
bbedward wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to set the app id per-window, in addition to the global //@ pragma AppId from #651.
Motivation: I'm planning to extract pieces of DMS into standalone apps, and a separate quickshell instance per app carries a lot of memory overhead (QML engine, GL context, etc. for each). The plan is an optional shared instance hosting multiple app windows, falling back to standalone instances when it isn't running, which needs per-window app ids for taskbar grouping, desktop entry matching, window rules, etc. Per-window app id was also suggested in #651.
I implemented as an attached property
Added a manual test that just verifies the value persists with visibility changes and can change even after top-level has already been mapped (that works on niri at least, not sure about other compositors)