Catalog: remove embed mode

[nl0]

Description

Retires the iframe-embeddable catalog variant ("embed mode") and all of its wiring and documentation. Embed was an always-on, unflagged surface (a separate /__embed route + layout variant) that every file/package-view change had to account for. Telemetry shows no customer-deployed embed instances, so this removes it wholesale rather than deprecating.

Removed

• App: the entire catalog/app/embed/ tree, constants/embed-routes.js, the legacy components/SearchResults module, and the now-dead utils/search hook (0 importers on master).
• Routes / serving: /__embed and /__embed-debug from nginx (nginx-web.conf), the dev server (webpack.dev.js), the prod Express middleware (frontendMiddleware.js), and the webpack entry points + HTML emit (webpack.base.js).
• Docs: the docs/Catalog/Embed.md integration guide, its SUMMARY.md nav entry and 3 screenshots, plus embed mentions in docs/README.md and .github/pull_request_template.md.

Notable edit

Search/NoResults.tsx was the only non-embed consumer of components/SearchResults (it imported ES_REF_SYNTAX); that constant is now inlined locally so the module can be deleted.

Verification

Full catalog CI pipeline run locally against current master, all green: npm run lint (prettier + eslint), npm run build (incl. TS typecheck — emits only the app entrypoint, no embed chunks), and npm test (117 files / 1075 tests, 1 skipped). No dangling references to any removed module/route remain. The deployment, enterprise, and e2e repos contain no references to the embed feature.

Coordination

⚠️ #4463 (Search: UI improvements) still imports ES_REF_SYNTAX from components/SearchResults and edits NoResults.tsx in the same region — whichever lands second needs ES_REF_SYNTAX reconciled. No other open PR touches the embed surface (#4925 gallery and #4937 preview are disjoint; #4995 Overview v2 is merged and clean).

Rebased fresh onto current master — the original draft no longer merged after the repo-wide .js→.jsx rename.

Greptile Summary

This PR removes the catalog embed mode and its supporting files.

• Deleted the embed app tree and embed route constants.
• Removed embed webpack entries, HTML outputs, and server rewrites.
• Deleted embed documentation and screenshots.
• Inlined the Elasticsearch syntax link used by Search/NoResults.tsx.

Confidence Score: 4/5

The changed flow looks mergeable after adding a clearer response for retired embed URLs.

• Deleted embed code no longer appears to have active in-repo importers.
• Fresh builds stop emitting embed assets.
• Removed embed URLs can still return the main SPA with a success response.

catalog/server/middlewares/frontendMiddleware.js, catalog/nginx-web.conf, catalog/internals/webpack/webpack.dev.js

Important Files Changed

Filename	Overview
catalog/server/middlewares/frontendMiddleware.js	Removes production Express handlers for the embed URLs, leaving them to the SPA wildcard fallback.
catalog/nginx-web.conf	Removes nginx rewrites and the special embeddable HTML location for embed files.
catalog/internals/webpack/webpack.base.js	Removes embed entry points and HTML generation from the webpack build.
catalog/internals/webpack/webpack.dev.js	Removes dev-server rewrites for /__embed and /__embed-debug.
catalog/app/containers/Search/NoResults.tsx	Replaces the deleted SearchResults import with the same local Elasticsearch syntax URL constants.

_{Reviews (1): Last reviewed commit: "remove embed" | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (7da9fa1) to head (428d039).

Files with missing lines	Patch %	Lines
catalog/app/containers/Search/NoResults.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4608      +/-   ##
==========================================
+ Coverage   48.35%   49.32%   +0.97%     
==========================================
  Files         856      843      -13     
  Lines       35092    34399     -693     
  Branches     5997     5822     -175     
==========================================
  Hits        16969    16969              
+ Misses      16152    15534     -618     
+ Partials     1971     1896      -75     

Flag	Coverage Δ
api-python	93.14% <ø> (ø)
catalog	24.86% <0.00%> (+0.75%)	⬆️
lambda	97.09% <ø> (ø)
py-shared	98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nl0]

@fiskus fyi.
greenlit by @kevinemoore quite a while ago iirc.