Skip to content

Add markdown#142

Open
statnmap wants to merge 3 commits into
r-lib:mainfrom
statnmap:add-markdown
Open

Add markdown#142
statnmap wants to merge 3 commits into
r-lib:mainfrom
statnmap:add-markdown

Conversation

@statnmap

Copy link
Copy Markdown
  • add gm_markdown_body() for a body in markdown
  • Markdown text is transformed into HTML using {markdown}
  • I updated doc and DESCRIPTION using attachment::att_amend_desc() as some deps in
    DESCRIPTION were not necessary anymore apparently

attachment::att_amend_desc(extra.suggests = "covr", pkg_ignore = "base") could be used after each dev modification.

statnmap added 3 commits July 22, 2020 14:31
- add `gm_markdown_body()` for a body in markdown
- Markdown text is transformed into HTML using {markdown}
- I updated doc and DESCRIPTION using `attachment::att_amend_desc()` as some deps in
DESCRIPTION were not necessary anymore apparently
@jimhester

Copy link
Copy Markdown
Member

Thanks for working on the PR. I think if we were going to add markdown support we should use the rmarkdown package rather than the markdown package.

Please remove the unrelated DESCRIPTION dependency changes.

@statnmap

statnmap commented Jul 28, 2020

Copy link
Copy Markdown
Author

I do not see in {rmarkdown} which function I can use to render a text fragment, other than creating a temporary external file to render with html_fragment() .
Did I miss something in the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants