[bug-hunter] Guard meeting capture against stale stop completions#1573
Merged
r3dbars merged 33 commits intoJul 23, 2026
Conversation
r3dbars
marked this pull request as ready for review
July 23, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Audio.stop()advances the capture generation synchronously but still emits its completion callback later with the stopped session's files.MeetingCaptureBridgepreviously matched that untagged callback to whichever stop continuation was current. If a timed-out meeting A was followed by meeting B, A's late callback could resolve B with A's files; starting B also discarded A's late-recovery callback.Fix
Evidence and scope
origin/main.Verification
bash run-tests.sh: 13,052 passed, 0 failed.bash run-tests.sh --filter testMeetingCaptureCompletionPolicy: 6 passed, 0 failed.git diff --check: passed.bash build-deps.sh --force: compiled 261 dependency targets, then environment-blocked while archivinglibExternalDeps.awitherrno=28(No space left on device).bash build.sh --no-open: blocked because the dependency archive was not produced.bash run-integration-smoke.sh: blocked because dependencies were unavailable.swift test: blocked by the same missing dependency setup (no such module: FluidAudio).