[bug-hunter] Make stats writes atomic on SQLite failure

[r3dbars]

Summary

Make recording and daily-activity statistics persistence fail together when SQLite rejects a write.

Evidence

recordSessionImpl already intended to wrap the recording insert and daily-activity update in one transaction, but ignored sqlite3_prepare and sqlite3_step failures. A rejected recording insert could therefore still commit the daily-activity update, making dashboard counts and duration disagree with recording history.

Fix

• Propagate prepare, step, BEGIN, and COMMIT failures through the transaction boundary.
• Roll back when any write fails.
• Add a regression test using a SQLite authorizer that denies recording inserts and verifies neither table changes.

Verification

• bash build-deps.sh --force
• swift test --filter StorageTests
• swift test
• bash build.sh --no-open
• bash run-tests.sh --filter RepoCommandContractTests
• bash run-tests.sh
• bash run-integration-smoke.sh
• codex review --base origin/main

All checks passed. The independent review found no actionable regressions. Hardware and manual UI proof were not required for this storage-only change and remain unperformed.