Closed
Fix quality_avg to average final_score instead of computing completion rate#2
Conversation
6 tasks
…on rate Co-authored-by: rafaelob <814981+rafaelob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on RBAC, Sign Languages, Skills, and Braille implementation
Fix quality_avg to average final_score instead of computing completion rate
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quality_avgwas reporting completion rate (completed traces / total traces × 100) rather than the average quality score fromfinal_scorevalues on each trace.Changes
observability.py: Replace the completion-rate formula with a proper average offinal_scoreacross completed traces that have a non-NonescoreFalls back to
0when no qualifying scores exist viamax(len(...), 1).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.