Cache fix adding support for filter routes - #254
Open
mr-loop-1 wants to merge 3 commits into
Open
Conversation
|
@mr-loop-1 is attempting to deploy a commit to the Raindrop Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253
Routing is
/collectionIdfor collections, and/0/<page specific>for filters, tags and all-bookmarks page.The cache mirrors that approach as a key-value object with key
collectionidfor collections and a key0for all these other pages. This makes the stored value against0get overwritten at every other page visit.Instead of caching everything using their own names, I have added the cache for filters using "0:type:name" as the key. Doing it for filters only since they are finite and get decided by api, so not have to be updated from client side.
Appending the key after '0' (esp when combined with parseInt) has the big advantage of reusing existing logic even with the modified keys.