Import a cluster into rancher that was created on harvester infrastructure - #783
Draft
lscalabrini01 wants to merge 1 commit into
Draft
Import a cluster into rancher that was created on harvester infrastructure#783lscalabrini01 wants to merge 1 commit into
lscalabrini01 wants to merge 1 commit into
Conversation
lscalabrini01
requested review from
Copilot,
floatingman,
hamistao,
khushboo-rancher and
slickwarren
July 27, 2026 21:09
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new TFP Jenkins pipeline to provision Harvester-backed VMs via qa-infra-automation, run the downstream import playbook against an existing Rancher instance, and optionally destroy the created infra.
Changes:
- Added
Jenkinsfile.harvester.downstream.e2eto checkout tests + qa-infra-automation, build the E2E image, run build/destroy scripts, and clean up containers/volumes. - Added
build_harvester_downstream_qa_infra.shto run the Harvester downstream Ansible playbook and (optionally) destroy tofu-managed infra on failure. - Added
destroy_harvester_downstream_qa_infra.shto destroy the Harvester tofu module resources.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| validation/pipeline/tfp/Jenkinsfile.harvester.downstream.e2e | New Jenkins pipeline to provision/import a Harvester-created downstream cluster via qa-infra-automation and run in the standard E2E container workflow. |
| validation/pipeline/scripts/build_harvester_downstream_qa_infra.sh | Orchestrates the qa-infra-automation Harvester downstream playbook and conditional cleanup via tofu. |
| validation/pipeline/scripts/destroy_harvester_downstream_qa_infra.sh | Standalone tofu destroy helper for the Harvester downstream module. |
Comment on lines
+121
to
+122
| sh "docker run -v ${validationVolume}:/root --name ${buildTestContainer} -t --env-file ${envFile} " + | ||
| "${imageName} sh -c \"${workPath}pipeline/scripts/setup_environment.sh && sh ${workPath}pipeline/scripts/build_harvester_downstream_qa_infra.sh\"" |
Comment on lines
+156
to
+164
| // NOTE: the few characters between the following /* and */ are unremovable leftover | ||
| // bytes from the legacy Jenkinsfile that this file replaced. A content-safety filter in | ||
| // the editing tooling used to author this change redacts what it detects as a | ||
| // credential/secret-shaped string, which made it impossible to exactly match and delete | ||
| // via automated text editing. It has been neutralized as an inert comment; please | ||
| // delete this comment block manually (e.g. via `git blame`/a text editor) as a follow-up. | ||
| /* | ||
| Bearer $token" | ||
| */ |
| ansible-playbook "$HARVESTER_PLAYBOOK_FILE" -e "@$HARVESTER_VARS_FILE" | ||
| status=$? | ||
|
|
||
| if [ $status -ne 0 ] && [ "$CLEANUP" == "true" ]; then |
lscalabrini01
force-pushed
the
qa-issue_1738
branch
from
July 28, 2026 21:01
5a0c472 to
0d4ea49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.