chore: revendor sc-publish version-floor fix - #533
Merged
randlee merged 1 commit intoAug 20, 2026
Conversation
Owner
Author
Final Quality ReportGenerated: 2026-08-20 Machine Status (JSON){
"sprint": "SC-COMPOSE-VERSION-FLOOR-REVENDOR-QA1",
"task": "sc-compose-version-floor-revendor-phase-q",
"branch": "fix/sc-compose-version-floor-revendor-phase-q",
"commit": "c3c4091",
"pr": 533,
"verdict": "PASS",
"findings": {
"blocking": 0,
"important": 0,
"minor": 1
},
"blocking_ids": [],
"merge_readiness": "ready",
"merge_reason": "All 5 stated deliverables independently verified closed with direct evidence (diff scope, byte-identical vendor/root mirrors confirmed against both the local worktree and actual upstream sc-publish@42e0fce, clean pytest run through the correctly-pinned venv). req-qa, arch-qa, and simplification-reviewer all PASS with 0 blocking/important findings; rust-qa-agent legitimately SKIPPED as out of scope for a pure-Python change. CI is fully green (14/14) and CLEAN. The RULE-012 violation class that FAILed PR #531 twice is conclusively closed at both the local-worktree and upstream-source level.",
"next_action": "none",
"owner": "none",
"recommendation": "Merge PR #533 into integrate/phase-q. This closes out the sc-compose version-floor RULE-012 saga (PR #531 x2 FAIL -> sc-publish PR #50 upstream fix -> this re-vendor). Route the noted pre-existing install.py --dry-run README drift to a separate backlog item; it does not block this PR."
}Validated Scope
Findings Summary (Final)
Residual Risks
Merge Readiness
RecommendationMerge PR #533 into integrate/phase-q. This closes out the sc-compose version-floor RULE-012 saga (PR #531 x2 FAIL -> sc-publish PR #50 upstream fix -> this re-vendor). Route the noted pre-existing install.py --dry-run README drift to a separate backlog item; it does not block this PR. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-vendors
plugins/sc-publish/(and its self-installed root mirror) from sc-publishdevelopcommit42e0fce, which merged the upstream version-floor fix (sc-publish PR #50). This closes out the version-floor saga: sc-compose PR #531 was FAILed twice for hand-patching vendored files; the actual fix landed upstream instead, and this PR only consumes it.Diff is exactly 4 mirrored files (root + vendored copies of
bootstrap_sc_compose.pyandtest_publish_kit_scripts.py) — no Q.4 release-candidate/provenance content, sinceintegrate/phase-qalready has that from PR #530/#532.Why
bootstrap_sc_compose.pyis vendored byte-for-byte into every consumer viainstall.py'spackage_files(). Consumer-side patches to it (attempted twice on PR #531) drift from the canonical source and were correctly rejected by QA. The fix belongs upstream, and this PR is the re-vendor step that closes the loop, following the same consume-update pattern as Q.3/Q.4.Test plan
python3 -m pytest .github/scripts/tests: 82 passed, 7 skipped, 3 subtestsgit diff --check: clean🤖 Generated with Claude Code