Skip to content

adding Coderabbit - #5638

Open
BradReesWork wants to merge 11 commits into
rapidsai:mainfrom
BradReesWork:coderabbit
Open

adding Coderabbit#5638
BradReesWork wants to merge 11 commits into
rapidsai:mainfrom
BradReesWork:coderabbit

Conversation

@BradReesWork

Copy link
Copy Markdown
Member

added the config files for running Coderabbit

@BradReesWork BradReesWork self-assigned this Aug 26, 2026
@BradReesWork
BradReesWork requested a review from a team as a code owner August 26, 2026 14:15
@BradReesWork BradReesWork added the improvement Improvement / enhancement to an existing function label Aug 26, 2026
@BradReesWork
BradReesWork requested review from a team as code owners August 26, 2026 14:15
@BradReesWork BradReesWork added the non-breaking Non-breaking change label Aug 26, 2026
@BradReesWork
BradReesWork marked this pull request as draft August 26, 2026 14:43
@copy-pr-bot

copy-pr-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@BradReesWork
BradReesWork marked this pull request as ready for review August 26, 2026 17:27

@seunghwak seunghwak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the C++ requirements include many cudf specific items. We need to delete them. Otherwise, looks like a good starting point.

Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
@BradReesWork
BradReesWork requested a review from seunghwak August 31, 2026 19:55

@seunghwak seunghwak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have

cugraph::detail::make_host_vector{,_async} or cugraph::detail::make_pinned_vector{,_async}, so the line mentioning these functions is irrelevant.

Otherwise, LGTM.

Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md Outdated
Comment thread cpp/REVIEW_GUIDELINES.md
Comment thread cpp/REVIEW_GUIDELINES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants