Skip to content

Fix two outdated facts in BUILDING.md - #356

Merged
will-v-pi merged 4 commits into
raspberrypi:developfrom
DanielMBouyou:fix-building-md-docs-width-and-libusb-list
Aug 12, 2026
Merged

Fix two outdated facts in BUILDING.md#356
will-v-pi merged 4 commits into
raspberrypi:developfrom
DanielMBouyou:fix-building-md-docs-width-and-libusb-list

Conversation

@DanielMBouyou

Copy link
Copy Markdown

CMakeLists.txt compiles DOCS_WIDTH=95; BUILDING.md still says 140. #334 changed it deliberately ("Reduce command width in the README"), a month after that sentence was last touched.

Without libusb six commands go, not five: bdev is missing.

Not fixed: the README otp permissions example passes --tx, which is not an option: the only --tx in any tracked C/C++ source, ever, is the --tx_remaining decrement in flash_id.c. That block also has device output I can't regenerate.

Comment thread BUILDING.md Outdated
@will-v-pi

Copy link
Copy Markdown
Contributor

Thanks, I've pushed a commit to this PR to address that final point about the picotool otp permissions output too

@lurch

lurch commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Not fixed: the README otp permissions example passes --tx, which is not an option

Curious. I wonder if that was from a previous version of https://github.com/raspberrypi/picotool#configuration ?

@will-v-pi On a side-note, https://github.com/raspberrypi/picotool#config doesn't explain what the -s flag stands for. And maybe it'd be nice if the picotool config examples showed a bi_ptr_int32 value being modified, in addition to the current bi_ptr_string "name" example. It's also not clear how the "group" mentioned at https://github.com/raspberrypi/picotool#config relates to the https://github.com/raspberrypi/picotool#binary-information
(And I also just noticed that it talks about bi_ptr_string in a couple of places, but that's not included in the "bunch of bi_ macros" list at https://github.com/raspberrypi/picotool#details )

@will-v-pi

Copy link
Copy Markdown
Contributor

Not fixed: the README otp permissions example passes --tx, which is not an option

Curious. I wonder if that was from a previous version of https://github.com/raspberrypi/picotool#configuration ?

It's from the internal RP2350 development pre-2.0.0 - the binary originally printed UART output, hence having a configurable TX pin, but that was removed before the 2.0.0 release and replaced with just an LED.

@will-v-pi On a side-note, https://github.com/raspberrypi/picotool#config doesn't explain what the -s flag stands for. And maybe it'd be nice if the picotool config examples showed a bi_ptr_int32 value being modified, in addition to the current bi_ptr_string "name" example. It's also not clear how the "group" mentioned at https://github.com/raspberrypi/picotool#config relates to the https://github.com/raspberrypi/picotool#binary-information (And I also just noticed that it talks about bi_ptr_string in a couple of places, but that's not included in the "bunch of bi_ macros" list at https://github.com/raspberrypi/picotool#details )

It stands for set (as in set <key> to <value>) - that is already fixed as part of #342, along with better documentation of group. This is just a quick demo, there is a much more complete example in pico-examples, so I don't think more needs adding here.

@DanielMBouyou

Copy link
Copy Markdown
Author

Both applied.

You're right the list wasn't exhaustive — I'd measured six commands dropping without libusb rather than five, so etc. is sturdier than any list I'd have written. Capitalised Pico on that line too.

Thanks for pushing the --tx fix, and for the pre-2.0.0 explanation — that answers it.

@will-v-pi will-v-pi added this to the 2.3.1 milestone Aug 12, 2026
@will-v-pi
will-v-pi merged commit 17abd0a into raspberrypi:develop Aug 12, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants