fix(docs): base-aware internal links - #32
Merged
Merged
Conversation
Raw HTML <a href="/en/..."> links bypass VitePress's `base` rewriting (only markdown and Vue Router links get the /property-testing/ prefix), so they pointed at the domain root and 404'd. Converted the five offending links: - docs/index.md language picker -> relative ./en/ ./ru/ (browser-resolved) - en/ru api/index.md + api/exceptions.md <small> blocks -> markdown links Added an integrity gate that fails the build on any raw HTML internal anchor, so this class of regression cannot recur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #31. The site
base: '/property-testing/'only applies to markdown links and Vue Router links — raw HTML<a href="/en/...">is not rewritten, so those links pointed at the domain root (rasuvaeff.github.io/en/→ 404).Fixed (5 links):
docs/index.mdlanguage picker → relative./en/./ru/(browser-resolved under base)en/ru api/index.md+api/exceptions.md<small>blocks → markdown links (base-applied)Regression guard:
check-integrity.mjsnow fails the build on any raw HTML internal<a href="/...">link, forcing the markdown form so VitePress appliesbase.Verified in the built dist: no
href="/en/..."remains; all internal links carry the/property-testing/prefix.