Skip to content

Add preparation time and recipe search#17

Open
rbola wants to merge 1 commit into
mainfrom
demo/prep-time
Open

Add preparation time and recipe search#17
rbola wants to merge 1 commit into
mainfrom
demo/prep-time

Conversation

@rbola

@rbola rbola commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Adds prep time getter and a recipe search endpoint.

Adds prep time getter and a recipe search endpoint.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rbola rbola closed this Jul 6, 2026
@rbola rbola reopened this Jul 6, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convention and security review

Reviewed the full PR diff against .cursor/rules/bitebyte-conventions.mdc.

Findings

Category Location Finding
Naming src/main/java/com/main/bitebyte/recipe/RecipeController.java:60 @GetMapping("/search") adds an action-style endpoint under recipes. The BiteByte REST convention requires plural resource nouns such as /recipes and /recipes/{id}; consider exposing search as a query on the recipes collection, e.g. GET /api/recipes?name=....
Naming src/main/java/com/main/bitebyte/recipe/Recipe.java:109 get_prep_time() uses snake_case. Java methods must use camelCase; rename this to a camelCase accessor such as getPrepTimeMinutes().
Security src/main/java/com/main/bitebyte/recipe/Recipe.java:26-27 MONGO_URI hardcodes a MongoDB connection string with credentials in source. Move connection strings/secrets to environment variables or a secret manager, and ensure no real credential remains in source control.
Security src/main/java/com/main/bitebyte/recipe/RecipeController.java:62-65 Raw @RequestParam String name is passed directly into Criteria.where("name").regex(name) and then mongoTemplate.find(...) with no validation or bounding. Validate and bound the input before querying, and escape/quote user text if regex matching is still needed.
Open in Web View Automation 

Sent by Cursor Automation: BiteByte PR Security Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant