Add preparation time and recipe search#17
Open
rbola wants to merge 1 commit into
Open
Conversation
Adds prep time getter and a recipe search endpoint. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Convention and security review
Reviewed the full PR diff against .cursor/rules/bitebyte-conventions.mdc.
Findings
| Category | Location | Finding |
|---|---|---|
| Naming | src/main/java/com/main/bitebyte/recipe/RecipeController.java:60 |
@GetMapping("/search") adds an action-style endpoint under recipes. The BiteByte REST convention requires plural resource nouns such as /recipes and /recipes/{id}; consider exposing search as a query on the recipes collection, e.g. GET /api/recipes?name=.... |
| Naming | src/main/java/com/main/bitebyte/recipe/Recipe.java:109 |
get_prep_time() uses snake_case. Java methods must use camelCase; rename this to a camelCase accessor such as getPrepTimeMinutes(). |
| Security | src/main/java/com/main/bitebyte/recipe/Recipe.java:26-27 |
MONGO_URI hardcodes a MongoDB connection string with credentials in source. Move connection strings/secrets to environment variables or a secret manager, and ensure no real credential remains in source control. |
| Security | src/main/java/com/main/bitebyte/recipe/RecipeController.java:62-65 |
Raw @RequestParam String name is passed directly into Criteria.where("name").regex(name) and then mongoTemplate.find(...) with no validation or bounding. Validate and bound the input before querying, and escape/quote user text if regex matching is still needed. |
Sent by Cursor Automation: BiteByte PR Security Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds prep time getter and a recipe search endpoint.