Fix AI attribute templates and review feedback - #5
Conversation
|
@codex review this PR as a solo local proposal-gate tool. Focus on practical reliability bugs, misleading docs, generated-state leakage, stale root/diff assumptions, Razor validation behavior, WinMerge/default diff behavior, and workflow confusion. Prefer small practical findings over broad platform redesign suggestions. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f7058d71f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ce3da9b to
b7a0d87
Compare
rdavi10471a2
changed the title
|
@codex review the updated combined PR. Since the last review, the branch was rebased onto current |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7a0d87214
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!string.IsNullOrWhiteSpace(explicitDiffToolPath)) | ||
| { | ||
| Console.WriteLine($"WARNING: Ignoring unsupported configured DiffTool '{diffTool}' because an explicit diff executable path was supplied."); | ||
| return true; |
There was a problem hiding this comment.
When a migrated local config has both an unsupported DiffTool value and any explicit diff executable path, this early return true exits before the ContractEnforcementMode validation below runs. In that scenario a typo such as ContractEnforcementMode: Strict is accepted and later resolves to Off, silently disabling the Roslyn gate during the exact stale-config migration path this change is meant to support. Please warn/allow the diff-tool override without returning before the rest of the config checks complete.
Useful? React with 👍 / 👎.
1 participant
Summary
DiffToolconfig values, so old copied monitors withDiffTool: VSCodecan be recovered without manually editing config first.AIWorkflowRunner.ExecutionFlow.mdso Roslyn preflight appears before proposed snapshot creation.Validation
dotnet build .\Monitor\AIWorkflowMonitor.csprojdotnet build .\Monitor\Docs\Samples\TinyConsoleWatchedProject\TinyConsoleWatchedProject.csprojReview focus
Please review this as a solo local proposal-gate tool. Focus on practical reliability bugs, misleading docs, generated-state leakage, stale config migration behavior, namespace/style consistency in generated watched-project helper files, and workflow confusion. Prefer small practical findings over broad platform redesign suggestions.