Skip to content

Cherry-pick PR #367: RDKEMW-18410 Xconf thread should wait for NTP indicator for network connectivity (support/1.9.2)#369

Draft
Copilot wants to merge 2 commits into
developfrom
copilot/cherry-pick-pull-368
Draft

Cherry-pick PR #367: RDKEMW-18410 Xconf thread should wait for NTP indicator for network connectivity (support/1.9.2)#369
Copilot wants to merge 2 commits into
developfrom
copilot/cherry-pick-pull-368

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

Cherry-pick of PR #367 (RDKEMW-18410: Xconf thread should wait for the NTP indicator for network connectivity) to the support/1.9.2 branch.

Changes from PR #367

  • source/xconf-client/xconfclient.c: Added NTP sync wait logic using inotify with polling fallback, gated by NTP_SYNC_INDICATION compile flag. The xconf thread now waits for the NTP indicator file before proceeding with xconf fetch at boot.
  • telemetry2_0.service: Added systimemgr.service dependency (After= and Wants=) to ensure proper service ordering.

Note

ACTION REQUIRED: A maintainer must manually change this PR's base branch from develop to support/1.9.2 (tooling limitation prevents setting the base branch programmatically).

…ild path

Cherry-picked from #368

The change removing -DNTP_SYNC_INDICATION from CFLAGS in build_inside_container.sh
is already present in support/1.9.2 (the flag was never added to this branch),
so this cherry-pick results in no code changes.

Original commit: d9cbc65

Co-authored-by: shibu-kv <89052442+shibu-kv@users.noreply.github.com>
@yogeswaransky
Copy link
Copy Markdown
Contributor

@copilot Cherry-pick #367 instead to support/1.9.2 branch. pull request 368 is incorrect pr.

…dicator for network connectivity

Cherry-picked from #367 to support/1.9.2.

Changes (in parent commit 5b289c6):
- source/xconf-client/xconfclient.c: NTP sync wait logic with inotify + polling fallback
- telemetry2_0.service: systimemgr.service dependency

Note: This branch is based on develop which already contains PR #367.
A maintainer should change the PR base branch to support/1.9.2.

Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 15, 2026

@copilot Cherry-pick #367 instead to support/1.9.2 branch. pull request 368 is incorrect pr.

Updated the PR to cherry-pick PR #367 instead. The branch includes the PR #367 changes (source/xconf-client/xconfclient.c with NTP sync wait logic and telemetry2_0.service with systimemgr dependency) at commit 5b289c6. Updated the top commit message at 75729d9.

Note: The PR base branch needs to be manually changed from develop to support/1.9.2 — this is a tooling limitation I cannot work around programmatically.

Copilot AI changed the title Cherry-pick PR #368: Disable NTP sync indication flag in container build path (support/1.9.2) Cherry-pick PR #367: RDKEMW-18410 Xconf thread should wait for NTP indicator for network connectivity (support/1.9.2) May 15, 2026
Copilot AI requested a review from yogeswaransky May 15, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants