Fix certificate path building at trust anchors - #11
Merged
Conversation
Prefer trust-store issuers when building from the leaf so server-supplied cross-signs beyond a valid anchor are ignored. Normalize issuer DNs and use AKI/SKI to disambiguate matching CA keys.
The previous fixture expired on 2026-07-29 and left TLS integration tests waiting until the CI timeout.
adiwajshing
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing (ignore for documentation update)
Type of change
Checklist:
Additional Notes:
The regression reproduces a chain that contains a trusted root cross-signed by an untrusted legacy root. It also generates certificates whose issuer and subject DNs differ in case and insignificant spacing, with matching and mismatching key identifiers.