docs(tasks): document account_id on DELETE /api/tasks - #283
Conversation
DELETE is the only task verb whose request schema lacks account_id — GET, POST and PATCH all accept the org/admin account context. This is the contract half of chat#1918; api follows. chat#1918
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe OpenAPI ChangesDelete task request
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contract for the
DELETE /api/tasksadmin-override row of chat#1918. Docs lead; the api PR follows and implements exactly this.What changes
Adds an optional
account_idtoDeleteTaskRequest, mirroring the wording already used onUpdateTaskRequest:requiredstays["id"]— the parameter is optional and existing callers are unaffected.Why
DELETEis the only task verb whose request schema lacks it. GET, POST and PATCH all accept the org/admin account context, so an admin key can create, read and edit a customer's task but gets 403 deleting it. Hit live on 2026-07-29 and again 2026-07-30; the workaround isPATCH {enabled:false}, whose re-sync also removes the Trigger schedule.The
403response is already documented on this operation, so no response codes change — this only makes the successful admin path expressible.Edit method
releases.jsondoes not round-trip byte-identically throughjson.load/json.dumps(verified), so this was applied as an anchored text edit at the property boundary rather than load→dump. Result re-validated: the file parses, andDeleteTaskRequest.propertiesis now['id', 'account_id']. Diff is 6 insertions, 0 deletions.Merge order
This PR first, then the api implementation. Linked from the #1918 matrix.
🤖 Generated with Claude Code
Summary by cubic
Added an optional
account_idtoDeleteTaskRequestforDELETE /api/tasks, enabling org/admin keys to delete a task in a specified account. This aligns DELETE with GET/POST/PATCH;idremains required and existing callers are unaffected.Written for commit ad35bb2. Summary will update on new commits.
Summary by CodeRabbit