PHP8: remove disable entity loader#642
Open
glaubinix wants to merge 1 commit into
Open
Conversation
codedino
approved these changes
Dec 15, 2021
codedino
left a comment
codedino
left a comment
There was a problem hiding this comment.
@judith @douglasmiller Our company is planning to upgrade to php 8, and when we tested it on Staging this deprecation message was reported.
We will really appreciate it if your team were to review the php 8 support for this package.
Thank you very much in advance.
|
@cyberxander90 can you please take a look ? |
|
Just chiming in to say that I've run into this same issue, and the fix here works for me. |
|
Same, and agreed, that fix appears to address the problem for PHP 8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.php.net/manual/en/function.libxml-disable-entity-loader.php