feat(validate-migration): add post-migration checks

[stevefulme1]

Summary

• Extends the existing validate_migration role with post-migration validation tasks (gated behind validate_migration_post_enabled: true)
• Validates VM configurations: spec fields, CPU/memory, volumes, network interfaces, VMI running status
• Validates data volumes: DataVolume phase (Succeeded), PVC bindings (Bound), storage sizes
• Validates network attachments: interface/network count match, NetworkAttachmentDefinitions, NetworkPolicies
• Validates resource relationships: VM-to-DataVolume references, orphaned DataVolumes, missing PVCs
• Adds playbooks/validate_migration.yml playbook

Resolves

MFG-423 — Migration Logic Validation and Testing

Usage

# Enable post-migration validation
validate_migration_post_enabled: true
validate_migration_post_namespace: "my-migrated-vms"

# Optional: filter VMs by label
validate_migration_post_label_selectors:
  - migration-plan=batch-01

# Optional: skip running status check
validate_migration_check_vm_running: false

Test plan

• Verify yamllint passes (confirmed locally)
• Verify ansible-lint --offline passes production profile (confirmed — 0 failures)
• Pre-migration checks still run as before (no regressions)
• Post-migration tasks skipped when validate_migration_post_enabled: false (default)
• Integration: validate VMs exist with correct spec after migration
• Integration: verify DataVolumes are Succeeded and PVCs are Bound
• Integration: verify network interfaces match network definitions
• Integration: detect orphaned DataVolumes and missing volume references

🤖 Generated with Claude Code

[spyrexd]

This is okay as long as the goal was just to validate the configuration has value set.

[sabre1041]

In addition to the comment regarding making prevalidation checks conditional, would you be able to rebase from main as there are corrections to variable names

[sabre1041]

In addition to the comment regarding making prevalidation checks conditional, would you be able to rebase from main as there are corrections to variable names

@stevefulme1 still need a rebase here to pick up the upstream variables

[sabre1041]

Content looks good. Just need to resolve the tests failure

[stevefulme1]

@sabre1041 Rebased on main, added pre-migration validation toggle (validate_migration_pre_enabled), and committed the auto-generated docs. Pre-commit checks pass now — CI is waiting on the external-approval environment gate to run the full test suite.

[sabre1041]

LGTM

[sabre1041]

Merging as failing slack notification is not part of this pr