Skip to content

FLPATH-4292 | [DCM] No i18n or translation support#3377

Merged
asmasarw merged 6 commits into
redhat-developer:mainfrom
asmasarw:feature/i18n
Jun 16, 2026
Merged

FLPATH-4292 | [DCM] No i18n or translation support#3377
asmasarw merged 6 commits into
redhat-developer:mainfrom
asmasarw:feature/i18n

Conversation

@asmasarw

@asmasarw asmasarw commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Tasks:

FLPATH-4292 | [DCM] No i18n or translation support


Changes:

  • Add internationalization (i18n) support using the Backstage translation API.
  • All hardcoded English strings are replaced with translation keys.
  • Includes locale files for de, es, fr, it, ja.

@asmasarw asmasarw requested review from a team, jkilzi and mareklibra as code owners June 11, 2026 11:23
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/dcm/packages/app none v0.0.1
@red-hat-developer-hub/backstage-plugin-dcm workspaces/dcm/plugins/dcm minor v1.0.0

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.37131% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.03%. Comparing base (8c5d14c) to head (09401a6).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
+ Coverage   53.46%   54.03%   +0.56%     
==========================================
  Files        2240     2411     +171     
  Lines       85510    87634    +2124     
  Branches    24167    24278     +111     
==========================================
+ Hits        45717    47351    +1634     
- Misses      39499    39968     +469     
- Partials      294      315      +21     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (-0.13%) ⬇️ Carriedforward from 0b349e2
ai-integrations 70.03% <ø> (+2.08%) ⬆️ Carriedforward from 0b349e2
app-defaults 69.60% <ø> (-0.20%) ⬇️ Carriedforward from 0b349e2
augment 46.39% <ø> (ø) Carriedforward from 0b349e2
bulk-import 72.80% <ø> (+0.34%) ⬆️ Carriedforward from 0b349e2
cost-management 17.48% <ø> (+3.37%) ⬆️ Carriedforward from 0b349e2
dcm 61.79% <76.37%> (+1.98%) ⬆️
extensions 62.17% <ø> (+0.63%) ⬆️ Carriedforward from 0b349e2
global-floating-action-button 74.30% <ø> (+3.12%) ⬆️ Carriedforward from 0b349e2
global-header 61.63% <ø> (+1.92%) ⬆️ Carriedforward from 0b349e2
homepage 52.60% <ø> (+2.76%) ⬆️ Carriedforward from 0b349e2
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from 0b349e2
konflux 91.01% <ø> (-0.49%) ⬇️ Carriedforward from 0b349e2
lightspeed 68.40% <ø> (-0.41%) ⬇️ Carriedforward from 0b349e2
mcp-integrations 85.46% <ø> (ø) Carriedforward from 0b349e2
orchestrator 37.33% <ø> (+0.77%) ⬆️ Carriedforward from 0b349e2
quickstart 62.09% <ø> (-1.91%) ⬇️ Carriedforward from 0b349e2
sandbox 79.56% <ø> (ø) Carriedforward from 0b349e2
scorecard 83.92% <ø> (+0.09%) ⬆️ Carriedforward from 0b349e2
theme 64.08% <ø> (+2.81%) ⬆️ Carriedforward from 0b349e2
translations 8.49% <ø> (+1.94%) ⬆️ Carriedforward from 0b349e2
x2a 78.79% <ø> (+0.10%) ⬆️ Carriedforward from 0b349e2

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c5d14c...09401a6. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mareklibra mareklibra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look into translation in the x2a workspace. There are tests for the refs - sort of comparing differences between ref.ts and translations. This is super useful later, during maintenance.

Comment thread workspaces/dcm/plugins/dcm/src/components/DcmDeleteDialog.tsx Outdated
Comment thread workspaces/dcm/plugins/dcm/src/pages/catalog-items/CatalogItemsTabContent.tsx Outdated
Comment thread workspaces/dcm/plugins/dcm/src/pages/policies/PoliciesTabContent.tsx Outdated
Comment thread workspaces/dcm/plugins/dcm/src/pages/service-types/ServiceTypesTabContent.tsx Outdated
Comment thread workspaces/dcm/plugins/dcm/src/pages/providers/providerFormTypes.ts
Comment thread workspaces/dcm/plugins/dcm/src/pages/policies/policyFormTypes.ts

@mareklibra mareklibra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please introduce the unit tests for translations as mentioned above. I just noticed there is already mismatch between the keys, e.g. validation.* is completely missing in translations

Comment thread workspaces/dcm/plugins/dcm/src/pages/providers/providerFormTypes.ts Outdated
Comment thread workspaces/dcm/plugins/dcm/src/pages/catalog-items/CatalogItemsTabContent.tsx Outdated
@asmasarw asmasarw requested a review from mareklibra June 15, 2026 11:38
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds a new top-level directory under workspaces/. Please follow Submitting a Pull Request for a New Workspace in CONTRIBUTING.md.

Comment thread workspaces/dcm/plugins/dcm/src/translations/ref.ts Outdated

@mareklibra mareklibra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment about component. It LGTM otherwise.

@asmasarw

Copy link
Copy Markdown
Contributor Author

One more comment about component. It LGTM otherwise.

Thanks @mareklibra - Changes were applied.

@asmasarw asmasarw requested a review from mareklibra June 16, 2026 13:08

@mareklibra mareklibra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, LGTM

@mareklibra mareklibra enabled auto-merge (squash) June 16, 2026 13:11
@asmasarw asmasarw disabled auto-merge June 16, 2026 13:39
@asmasarw asmasarw enabled auto-merge (squash) June 16, 2026 13:40
@sonarqubecloud

Copy link
Copy Markdown

@asmasarw asmasarw merged commit 50be9f2 into redhat-developer:main Jun 16, 2026
14 checks passed
@asmasarw asmasarw deleted the feature/i18n branch June 16, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants