FLPATH-4292 | [DCM] No i18n or translation support#3377
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
+ Coverage 53.46% 54.03% +0.56%
==========================================
Files 2240 2411 +171
Lines 85510 87634 +2124
Branches 24167 24278 +111
==========================================
+ Hits 45717 47351 +1634
- Misses 39499 39968 +469
- Partials 294 315 +21
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
mareklibra
left a comment
There was a problem hiding this comment.
Please have a look into translation in the x2a workspace. There are tests for the refs - sort of comparing differences between ref.ts and translations. This is super useful later, during maintenance.
mareklibra
left a comment
There was a problem hiding this comment.
Please introduce the unit tests for translations as mentioned above. I just noticed there is already mismatch between the keys, e.g. validation.* is completely missing in translations
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request adds a new top-level directory under |
mareklibra
left a comment
There was a problem hiding this comment.
One more comment about component. It LGTM otherwise.
Thanks @mareklibra - Changes were applied. |
mareklibra
left a comment
There was a problem hiding this comment.
Thank you for the changes, LGTM
|



Tasks:
FLPATH-4292 | [DCM] No i18n or translation support
Changes: