Close sessions from panes + review/answer plans in the reader#3
Draft
lacraig2 wants to merge 4 commits into
Draft
Close sessions from panes + review/answer plans in the reader#3lacraig2 wants to merge 4 commits into
lacraig2 wants to merge 4 commits into
Conversation
ExitPlanMode plans were reduced to a one-line prompt, so a plan could only be reviewed in the raw terminal (where it's usually too long to read). Carry the full plan markdown through ParsedMenu.detail -> PendingOptions.detail and render it in OptionPicker as a scrollable, expandable block right above the choices, so a plan is reviewable exactly where it's answered (drive cockpit + panes reader). The detail is folded into the selection fingerprint so a re-issued plan with the same one-line prompt can't be answered from a stale view.
Permission menus and AskUserQuestion/ExitPlanMode prompts are terminal overlays; in reader (conversation) mode they were either invisible or buried inside a collapsed 'N steps' tool run, so the user had to switch to the terminal to see a question or a plan. Render ExitPlanMode as the plan itself (markdown inline, expanded by default in focus/reader mode, collapsible) and AskUserQuestion as its question + choices, and exclude both from tool-run grouping so they always stand alone.
Closing a session was only reachable from the row's ⋯ menu (a danger row) and, in the open-pane deck, from a desktop-only menu — so on a phone there was no accessible way to close a session. Add an always-visible ✕ on each task row that opens the existing confirm dialog (RemoveDialog), so it's one tap to reach but never destructive by accident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related cockpit asks. Builds on the current
round-5-cockpitworking tree(the first commit is a snapshot of in-progress local changes, per request).
1. Prominent close (✕) on task rows —
feat(panes)Closing a session was only reachable from the row's
⋯menu (a buried dangerrow) and, in the open-pane deck, from a desktop-only menu — so on a phone
there was no accessible way to close a session. Adds an always-visible
✕oneach task row that opens the existing confirm dialog (
RemoveDialog): one tap toreach, still gated so it's never destructive by accident.
2. Answer questions without leaving the reader —
feat(viewer)Permission menus and
AskUserQuestion/ExitPlanModeprompts are terminaloverlays; in reader (conversation) mode they were invisible or buried inside a
collapsed "N steps" tool run, forcing a switch to the terminal to answer.
ExitPlanModenow renders as the plan itself — markdown inline, expandedby default in the reader, collapsible.
AskUserQuestionrenders as its question + choices inline.3. Review plans where you answer them —
feat(options)ExitPlanModeplans were reduced to a one-line prompt, so a plan could only beread in the raw terminal (usually too long to scroll there). The full plan body
now rides through
ParsedMenu.detail → PendingOptions.detailand renders inOptionPickeras a scrollable, expandable block right above the choices — so theplan is reviewable exactly where it's answered, in both the drive cockpit and the
panes reader. The plan body is folded into the selection fingerprint so a
re-issued plan can't be answered from a stale view.
Tests
424 passed(adds plan-detail + fingerprint coverage intest_options.py).102 passed(addsOptionPicker, inline plan/question render, TaskRowclose, and tool-run exclusion tests).
Note on the base
The branch's first commit snapshots uncommitted local work that was already on
round-5-cockpit; the threefeat(...)commits are the actual change. When youcommit your own WIP, reconcile as needed.