Remove macOS Electron system tray in favor of remoteit-tray#1128
Draft
JamieRuderman wants to merge 1 commit into
Draft
Remove macOS Electron system tray in favor of remoteit-tray#1128JamieRuderman wants to merge 1 commit into
JamieRuderman wants to merge 1 commit into
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — depends on remoteit-tray shipping. See⚠️ below before merging.
What
On macOS, stop creating the Electron
Tray+TrayMenu. The menu-bar tray is now provided by the standalone remoteit-tray app (incli-source), so it lives with the agent and survives this app being quit — the original motivation.createSystemTray()skips the tray on macOS (environment.isMac); the application menu setup is unchanged. Windows/Linux keep the Electron tray until remoteit-tray supports them (Phase 3).openWindow()no longer gates onthis.tray(it was only a guard, not a positioning anchor). The window is driven by the existingactivate/open-urlhandlers, so the standalone tray's "Open remote.it Desktop" item works.TrayMenu.tsis retained (still used on Windows/Linux).Companion CLI PR: remoteit/cli-source#426
remoteit-tray is not yet bundled or auto-installed by this app. If this merges/ships as-is, macOS users would lose their tray entirely until they manually install remoteit-tray. This PR should land only alongside (or after) the follow-up that:
remoteit-tray.appin the desktop app's resources, andremoteit-tray install),plus codesigning/notarization of the bundled binary. Kept as a draft until then.
Typecheck
tsc -p electron/tsconfig.json --noEmitclean.