Fix URL handling in menu item generation

[aa9772]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @aa9772, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with how URLs are constructed for the main navigation menu. By transitioning from absolute to relative URL generation, the change significantly improves the flexibility and portability of the website's menu links, ensuring they operate correctly across diverse deployment environments without reliance on a static base URL.

Highlights

• URL Generation for Menu Items: The method for generating URLs for main menu items has been updated. Specifically, the absURL function has been replaced with relURL in layouts/partials/header.html.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix URL handling for menu items by switching from absolute URLs (absURL) to relative URLs (relURL). While using relative URLs is a good practice for portability, this change as-is introduces a bug. The logic for highlighting the active menu item will break because it compares an absolute page URL with the new relative menu item URL. I've added a comment explaining the issue and suggesting how to complete the fix by ensuring both URLs are relative for the comparison.

[gemini-code-assist]

Changing absURL to relURL here makes the menu item URL relative, but this breaks the logic for highlighting the active menu item on line 136. The check strings.HasPrefix $page_url $menu_item_url will now compare an absolute URL ($page_url from .Permalink) with a relative URL ($menu_item_url), which will likely always fail.

To fix this, you also need to update the definition of $page_url on the next line to use a relative URL, for example by using $currentPage.RelPermalink.