chore: hardcode secure site SDK URL to preview deployment#5686
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
|
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=933 👉 Please review the visual changes in Chromatic and accept or reject them. |
There was a problem hiding this comment.
Pull request overview
This PR aims to point the embedded “secure site SDK” iframe to a specific preview deployment (https://9aaf2d1a.secure-appkit-sdk.pages.dev) and updates the Laboratory app’s CSP so that the iframe is permitted to load.
Changes:
- Hardcodes
SECURE_SITE_SDKto the preview deployment URL in the wallet package. - Updates Laboratory CSP
frame-srcto allow the preview deployment origin.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/wallet/src/W3mFrameConstants.ts |
Replaces env-var-driven Secure Site SDK URL selection with a hardcoded preview URL. |
apps/laboratory/middleware.ts |
Adds the preview deployment origin to the CSP frame-src allowlist so the iframe is not blocked. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Hardcoded secure site SDK URL | ||
| export const SECURE_SITE_SDK = 'https://9aaf2d1a.secure-appkit-sdk.pages.dev' |
| font-src 'self' https://fonts.gstatic.com https://fonts.reown.com; | ||
| connect-src 'self' https://react-wallet.walletconnect.com https://rpc.walletconnect.com https://rpc.walletconnect.org https://relay.walletconnect.com https://relay.walletconnect.org wss://relay.walletconnect.com wss://relay.walletconnect.org https://pulse.walletconnect.com https://pulse.walletconnect.org https://api.web3modal.com https://api.reown.com https://api.web3modal.org wss://www.walletlink.org https://o1095249.ingest.sentry.io https://quote-api.jup.ag https://mempool.space https://cca-lite.coinbase.com https://registry.npmjs.org ${publicNodeDomains.join(' ')} ${tronFullnodeDomains.join(' ')}; | ||
| frame-src 'self' https://verify.walletconnect.com https://verify.walletconnect.org https://secure.walletconnect.com https://secure.walletconnect.org https://secure.reown.com ${secureSiteDomain}; | ||
| frame-src 'self' https://verify.walletconnect.com https://verify.walletconnect.org https://secure.walletconnect.com https://secure.walletconnect.org https://secure.reown.com https://9aaf2d1a.secure-appkit-sdk.pages.dev ${secureSiteDomain}; |
|
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Hardcodes the secure site SDK URL to the preview deployment at
https://9aaf2d1a.secure-appkit-sdk.pages.dev.