ci(walletkit-maestro): don't fail job on transient artifact upload errors#550
Merged
Merged
Conversation
…rors Maestro artifact uploads are diagnostic-only. A transient network failure reaching GitHub's artifact backend (e.g. ENOTFOUND on CreateArtifact) was failing the whole job even after all tests passed. Mark both the iOS and Android upload steps continue-on-error so they no longer gate the job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task in 44s —— View job Review in progress
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the WalletKit Maestro composite GitHub Action so that transient network/DNS failures during artifact upload (iOS/Android Maestro diagnostics) no longer fail an otherwise-green CI run.
Changes:
- Mark the iOS Maestro artifact upload step as
continue-on-error: true. - Mark the Android Maestro artifact upload step as
continue-on-error: true. - Add inline comments clarifying these artifacts are diagnostic-only and shouldn’t gate CI success.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
continue-on-error: trueto both Maestro artifact upload steps (iOS and Android) in.github/actions/walletkit-build-and-maestro/action.yml.Why
A recent CI run had all Maestro tests pass, but the job still went red because the post-test artifact upload failed at the network layer:
This is a transient DNS/network error on the runner reaching GitHub's artifact backend — not a code or test failure.
These artifacts (screenshots, recordings, logs) are diagnostic-only and shouldn't gate the job. With this change, a flaky upload is still surfaced as a failed step but no longer fails the whole job after tests have passed.
The actual test result is still enforced by
exit "$maestro_exit_code"inside the Maestro test step, so real test failures continue to fail the job.🤖 Generated with Claude Code