Skip to content

add rhel 10.1 support#6028

Open
xavpaice wants to merge 4 commits into
mainfrom
rocky10-1
Open

add rhel 10.1 support#6028
xavpaice wants to merge 4 commits into
mainfrom
rocky10-1

Conversation

@xavpaice

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Adds Rocky/RHEL 10.1

@xavpaice xavpaice requested a review from a team as a code owner June 11, 2026 23:36
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "add rhel 10.1 support" | Re-trigger Greptile

@nvanthao nvanthao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testgrid image need to be updated as well

vmimageuri: https://dl.rockylinux.org/pub/rocky/10/images/x86_64/Rocky-10-GenericCloud-Base.latest.x86_64.qcow2

and then there's doc update, e.g. replicatedhq/kurl.sh#1277

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown

Reviews (2): Last reviewed commit: "update testgrid OS spec" | Re-trigger Greptile

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown

Comments Outside Diff (1)

  1. scripts/common/host-packages.sh, line 297-301 (link)

    P1 docker-ce --allowerasing fix not applied to the el9/el10 path

    _yum_install_host_packages (el8) was extended to use --allowerasing when docker-ce is in the package list, but the parallel _yum_install_host_packages_el9 function — which is called for RHEL/Rocky 9 and 10 (including the newly-supported 10.1) — still only triggers --allowerasing for containerd.io. If docker-ce can cause package conflicts requiring --allowerasing on el8, the same condition can arise on el9/el10.

Reviews (3): Last reviewed commit: "remove obsolete OSs from Testgrid" | Re-trigger Greptile

@xavpaice

Copy link
Copy Markdown
Member Author

Kicked a Testgrid from this branch: https://testgrid.kurl.sh/run/STAGING-manual-51a1dca-2026-06-12T02:29:02Z

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown

Comments Outside Diff (2)

  1. testgrid/specs/os-latest.yaml, line 33-36 (link)

    P1 The rocky-10 entry in os-latest.yaml still reports version: "10.0", while the same entry in os-firstlast.yaml and os-full.yaml was updated to "10.1" in this PR. According to the README added here, os-latest.yaml is the default OS pool for release and addon tests — leaving the version label stale means release CI will log "Rocky 10.0" results even when the underlying image is already 10.1.

  2. scripts/common/host-packages.sh, line 297-301 (link)

    P1 The docker-ce/--allowerasing fix added to the el8 path was not extended to _yum_install_host_packages_el9, which now handles RHEL/Rocky 9 and 10.1 (as newly supported by this PR). If docker-ce causes a package conflict on el9/el10 — the same scenario that motivated the el8 fix — installations on those platforms will fail without --allowerasing.

Reviews (4): Last reviewed commit: "clear up some older tests" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants