feat(domains): add click_tracking and open_tracking to CreateParams#200
Merged
feat(domains): add click_tracking and open_tracking to CreateParams#200
Conversation
Allow specifying click and open tracking options when creating a domain, rather than requiring a separate update call after creation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
115610b to
ec6ff9f
Compare
drish
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
click_trackingandopen_trackingoptional fields toDomains.CreateParams, allowing these to be set at domain creation time instead of requiring a separate update callTest plan
python -m pytest tests/domains_test.py tests/domains_async_test.py -v🤖 Generated with Claude Code
Summary by cubic
Add optional
click_trackingandopen_trackingtoDomains.CreateParamsto enable click and open tracking at domain creation, avoiding a follow-up update. Updated sync and async tests to cover these params; bumped package version to2.29.0.Written for commit 3e415c7. Summary will update on new commits.