Skip to content

feat(domains): add click_tracking and open_tracking to CreateParams#200

Merged
drish merged 2 commits intomainfrom
feat/domain-create-tracking-options
Apr 16, 2026
Merged

feat(domains): add click_tracking and open_tracking to CreateParams#200
drish merged 2 commits intomainfrom
feat/domain-create-tracking-options

Conversation

@rehanvdm
Copy link
Copy Markdown
Contributor

@rehanvdm rehanvdm commented Apr 16, 2026

Summary

  • Add click_tracking and open_tracking optional fields to Domains.CreateParams, allowing these to be set at domain creation time instead of requiring a separate update call
  • Update sync and async tests to exercise the new create params

Test plan

  • Verified Python syntax parses correctly
  • Run python -m pytest tests/domains_test.py tests/domains_async_test.py -v

🤖 Generated with Claude Code


Summary by cubic

Add optional click_tracking and open_tracking to Domains.CreateParams to enable click and open tracking at domain creation, avoiding a follow-up update. Updated sync and async tests to cover these params; bumped package version to 2.29.0.

Written for commit 3e415c7. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@drish drish changed the base branch from feat/tracking-caa-record to main April 16, 2026 12:53
@drish drish self-requested a review April 16, 2026 12:53
Allow specifying click and open tracking options when creating a domain,
rather than requiring a separate update call after creation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@drish drish force-pushed the feat/domain-create-tracking-options branch from 115610b to ec6ff9f Compare April 16, 2026 12:54
@drish drish merged commit 3854817 into main Apr 16, 2026
20 checks passed
@drish drish deleted the feat/domain-create-tracking-options branch April 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants