fix(View): pass fallbackKey to renderItem in default children branch - #653
Open
cricrimessina wants to merge 1 commit into
Open
fix(View): pass fallbackKey to renderItem in default children branch#653cricrimessina wants to merge 1 commit into
cricrimessina wants to merge 1 commit into
Conversation
Contributor
|
@cricrimessina Hey, thanks for the PR, is this happening for you in React 18 or 19? I tried running fable against the PR trying to better understand the edge cases and it suggested that it shouldn't be happening in React 19 today already |
Author
|
@blvdmitry Hi, thanks for looking into it! I reproduced this on React 19 (specifically 19.2.8).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for React key warning. In
View'srenderItem, the default branch (used when a child doesn't match theHiddenor multi-childFragmentcases) never passes afallbackKey, unlike the other two branches. So when aView/View.Itemchild has no explicitkey, the wrappingFragmentends up keyed withundefined— hence the "Each child in a list should have a unique key prop" warning.Fix: pass
usedIndexasfallbackKey, same as the other branches already do.Related Issue
None — found while debugging a React key warning in a consuming app.
Screenshots / Recordings
No visual change, just a fix for a console warning.
Notes for Reviewers
Single line change:
Example that triggers the warning before this fix — plain text and a
<br />as direct children, none with an explicit key: