Skip to content

chore: sync from monorepo @46bbacc#28

Open
WomB0ComB0 wants to merge 1 commit intomainfrom
sync/monorepo-46bbacc
Open

chore: sync from monorepo @46bbacc#28
WomB0ComB0 wants to merge 1 commit intomainfrom
sync/monorepo-46bbacc

Conversation

@WomB0ComB0
Copy link
Copy Markdown
Member

Automated sync from resq-software/resQ@46bbacc.

Review before merging — direct pushes to standalone repos are preserved.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@WomB0ComB0 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 6 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0e9b54e-e415-4312-815d-f6d35523cd12

📥 Commits

Reviewing files that changed from the base of the PR and between 2ce6f0e and a08aa0a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (22)
  • .gitignore
  • osv-scanner.toml
  • resq-airspace/src/error.rs
  • resq-airspace/src/instructions/grant_permit.rs
  • resq-airspace/src/instructions/initialize_property.rs
  • resq-airspace/src/instructions/record_crossing.rs
  • resq-airspace/src/instructions/update_policy.rs
  • resq-airspace/src/instructions/update_treasury.rs
  • resq-airspace/src/lib.rs
  • resq-airspace/src/state/airspace_account.rs
  • resq-airspace/src/state/mod.rs
  • resq-airspace/src/state/permit.rs
  • resq-airspace/tests/host_init_regression.rs
  • resq-airspace/tests/integration.rs
  • resq-delivery/src/error.rs
  • resq-delivery/src/instructions/mod.rs
  • resq-delivery/src/instructions/record_delivery.rs
  • resq-delivery/src/lib.rs
  • resq-delivery/src/state/delivery_record.rs
  • resq-delivery/src/state/mod.rs
  • resq-delivery/tests/integration.rs
  • vendor/solana-program-test/osv-scanner.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/monorepo-46bbacc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 6 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a broad cleanup of the codebase, including the removal of configuration files like .gitignore and osv-scanner.toml, refactoring range checks into explicit comparisons, and adjusting Clippy attributes. However, several critical issues were identified: the downgrade of the rand crate re-introduces a known security vulnerability (RUSTSEC-2026-0097), and the removal of osv-scanner.toml deletes essential security context for vulnerability management. Additionally, removing the clippy::too_many_arguments suppression on the initialize_property handler is expected to break CI builds given the function's high argument count.

Comment thread Cargo.lock
"log",
"lz4",
"rand 0.8.6",
"rand 0.8.5",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Downgrading rand from 0.8.6 to 0.8.5 (and 0.9.3 to 0.9.2 elsewhere in this file) re-introduces a known unsoundness issue (RUSTSEC-2026-0097) where rand::rng() can be unsound when a custom logger is installed. The removed osv-scanner.toml explicitly identified the newer versions as the fixed ones. This regression should be reverted unless there is a specific compatibility requirement forcing the older versions.

/// * `fee_lamports` – per-crossing fee (0 = free)
/// * `treasury` – SOL account that receives crossing fees
#[allow(clippy::too_many_arguments)]
pub fn handler(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of #[allow(clippy::too_many_arguments)] here will likely cause Clippy to fail in CI, as the handler function takes 9 arguments, exceeding the default threshold of 7. Since the global allow in lib.rs was also removed, this attribute should be restored to maintain CI stability.

Suggested change
pub fn handler(
#[allow(clippy::too_many_arguments)]
pub fn handler(

Comment thread osv-scanner.toml
@@ -1,58 +0,0 @@
# OSV-Scanner configuration for resq-software/programs.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing this configuration file deletes important security context and rationales for ignoring transitive vulnerabilities that are currently blocked by upstream dependencies (like Anchor or Solana). This will likely cause security scanning tools to fail in CI without providing the necessary context for the ignores. If security configuration is being centralized in the monorepo, ensure these rationales are preserved at the root level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant