fix various warnings - #1
Open
0xAdk wants to merge 4 commits into
Open
Conversation
It seems like switch-tools was removed from libhakkun's nix/default.nix file. There was only result online of a `switch-tools` package so I chose to vender it instead of remove the `SWITCHTOOLS` env var since I don't know what it's for.
These flags were unset and generating warnings about the default values they were defaulting to. This simply copies those default values to silence the warnings.
I'm not sure if this is the correct solution. Usually when cross compiling under nix you'd want setup nixpkgs to use the correct `crossSystem`. This is because compilers usually get wrapped differently based on the different target they are going to be used to build for, but I wasn't able to get that to work in testing.
It would be preferable to only silence these warnings when building the dependencies themselves, but that's only possible if the dependencies were being added using cmakes more modern target system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes most of the warnings produced by the cmake configuration, cmake build, and some from the cc-wrapper when building using the nix devshell.