feat: migrate settings UI to declarative API#18
Draft
rhoades-brown wants to merge 2 commits into
Draft
Conversation
5d086b6 to
a9f5b1d
Compare
efd3e62 to
bd9eaf4
Compare
bd9eaf4 to
ec41f6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the settings tab from the imperative
display()method to the new declarative Settings API introduced in Obsidian 1.13.0, and adds additional 1.13.0 API enhancements.Declarative Settings Migration
display()withgetSettingDefinitions()returning an array of declarative definitionsgetControlValue/setControlValuewith dot-notation support for nested settings objectsrendercallbacks for connection status and Connect buttonrendercallbacktype: 'list'with page navigationtype: 'list'with inline editingvisiblepredicates (interval slider only shown when enabled)controlbindingsrendercallbacks for side-effects (logger.configure())this.display()calls replaced withthis.update()eslint-disablecomments removed1.13.0 API Enhancements
confirmDestructiveActionhelper using nativeConfirmationModalAPI for delete repo and clear logs confirmationssetControlValueto usesaveSettings()instead ofsaveData()to preserve sync stateBreaking Change
minAppVersionbumped from1.7.2to1.13.0Checklist