feat: add ability to swap kpi theme per measures#9281
Open
Conversation
Introduces a per-measure `inverse_theme` option that swaps the `kpi-positive` and `kpi-negative` theme colors for measures where a decrease is the favourable outcome (e.g. bounce rate, error rate). Wires the flag through the canvas KPI, big-number, leaderboard, and pivot delta surfaces, and adds a toggle to the visual metrics editor. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The previous commit regenerated Go + OpenAPI bindings but missed the protobuf-es TS output, so `GetResource`'s `toJson()` silently dropped the new field and the frontend never saw `inverseTheme: true`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on discussion: https://linear.app/rilldata/issue/APP-808/make-positive-numbers-green-in-dashboards#comment-cb9e154d
https://rilldata.slack.com/archives/C0ASRK17C59/p1776814974047379
Missing components
Checklist: