fix(ui): catch bg-emerald-50 trial banner in dark-mode pill rules#62
Merged
Conversation
PR #61 dimmed the grade-pill compound rule but only matched the bg-{color}-100.text-{color}-700 combination. The anon trial banner ("50 of 50 free grades remaining this session") in index.html uses bg-emerald-50.text-emerald-700 — different class combo, slipped past the rule and continued rendering at light-mode saturation. Extend each color's compound rule to cover the -50 variant too (emerald, lime, amber, orange, red). Add emerald-50.text-emerald-900 since query_with_context.html uses that pair. Now matches the ambient-pill treatment everywhere those classes appear: trial banner, grade-A surfaces in compare_results / contextualized results, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #61. The compound pill rule only matched
bg-{color}-100.text-{color}-700, so the anon trial banner (bg-emerald-50.text-emerald-700inindex.html) still rendered at light-mode saturation. Extends each color's rule to cover-50variants too.