Skip to content

perf(runner): refactor requestToActor to O(1) Map #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iinaa-eimrit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(runner): refactor requestToActor to O(1) Map #5635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions rivetkit-typescript/packages/engine-runner/src/tunnel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,7 @@ export class Tunnel {
#runner: Runner;

/** Maps request IDs to actor IDs for lookup */
#requestToActor: Array<{
gatewayId: GatewayId;
requestId: RequestId;
actorId: string;
}> = [];
#requestToActor = new Map<string, string>();

/** Buffer for messages when not connected */
#bufferedMessages: Array<{
Expand Down Expand Up @@ -114,7 +110,7 @@ export class Tunnel {
}

// Clear the request-to-actor mapping
this.#requestToActor = [];
this.#requestToActor.clear();
}

async restoreHibernatingRequests(
Expand Down Expand Up @@ -414,44 +410,36 @@ export class Tunnel {
requestId: RequestId,
actorId: string,
) {
this.#requestToActor.push({ gatewayId, requestId, actorId });
const key = `${idToStr(gatewayId)}:${idToStr(requestId)}`;
this.#requestToActor.set(key, actorId);
}

#removeRequestToActor(gatewayId: GatewayId, requestId: RequestId) {
const index = this.#requestToActor.findIndex(
(entry) =>
arraysEqual(entry.gatewayId, gatewayId) &&
arraysEqual(entry.requestId, requestId),
);
if (index !== -1) {
this.#requestToActor.splice(index, 1);
}
const key = `${idToStr(gatewayId)}:${idToStr(requestId)}`;
this.#requestToActor.delete(key);
}

getRequestActor(
gatewayId: GatewayId,
requestId: RequestId,
): RunnerActor | undefined {
const entry = this.#requestToActor.find(
(entry) =>
arraysEqual(entry.gatewayId, gatewayId) &&
arraysEqual(entry.requestId, requestId),
);
const key = `${idToStr(gatewayId)}:${idToStr(requestId)}`;
const actorId = this.#requestToActor.get(key);

if (!entry) {
if (!actorId) {
this.log?.warn({
msg: "missing requestToActor entry",
requestId: idToStr(requestId),
});
return undefined;
}

const actor = this.#runner.getActor(entry.actorId);
const actor = this.#runner.getActor(actorId);
if (!actor) {
this.log?.warn({
msg: "missing actor for requestToActor lookup",
requestId: idToStr(requestId),
actorId: entry.actorId,
actorId,
});
return undefined;
}
Expand Down