Fix shellcode dialog dropping trailing odd nibble - #3650
Open
DaxRay wants to merge 1 commit into
Open
Conversation
Pad a lone trailing hex digit with 0 so odd-length shellcode input is not silently truncated (rizinorg#2831).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0when loading shellcode from the New File dialog, so odd-length input is not silently discarded (fixes Cutter GUI trimms shell code to whole bytes (might discard last nibble) #2831).Test plan
abc→ Load → memory should contain0xab 0xc0(not only0xab)abcd→ still loads0xab 0xcdunchanged