Remove unreachable NCCL broadcast receiver code#13
Open
TianyeGGBond wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NotImplementedErrorinMegatronTrainRayActor._dispatch_nccl_broadcast.Why
The sender-side NCCL implementation is intentionally not available yet, so
_dispatch_nccl_broadcastmust fail before receiver engines enter collective setup and wait for a rank-0 sender that never joins. The old version correctly protected that path, but left about 50 lines of permanently unreachable receiver fan-out code after the raise. That dead code creates review and lint noise without changing behavior.Validation
python -m py_compile miles/backends/megatron_utils/actor.pygit diff --check