Develop

[robinonsay]

No description provided.

[Copilot]

Pull Request Overview

This PR represents a major refactoring and modernization of the Juno embedded C library, focusing on simplifying APIs, improving modularity, and enhancing developer experience. The changes span across core modules including hash maps, memory management, time handling, and build systems.

Key changes include:

• Complete overhaul of the hash map API from JUNO_MEMORY_T-based to void pointer-based interface
• Removal of hash module dependencies and consolidation of CRC functionality
• Syntax fixes for macro usage throughout the codebase (JUNO_ASSERT_SUCCESS parameter handling)

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 50 comments.

Show a summary per file

File	Description
tests/test_map.c	Complete rewrite with new test framework using direct API calls instead of module-based approach
tests/test_heap.c	Updated test expectations for error propagation in heap delete operations
tests/test_hash.c	Entire file removed as part of hash module elimination
tests/test_cpp.cpp	Updated include dependencies removing hash and string modules
src/juno_map.c	Simplified map implementation focusing on index-based operations
src/juno_time.c	Fixed type usage and improved documentation comments
src/juno_memory_block.c	Corrected macro syntax for error handling
include/juno/map/map_api.h	Complete API redesign with simplified void pointer interface
include/juno/module.h	Enhanced with new utility macros for result and option handling
CMakeLists.txt	Added new build options for freestanding, ASAN, and UBSAN support

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tests/test_map.c:1

• This test assertion expects Delete to fail when Reset fails, but the function call is JunoDs_Heap_Delete which is a heap operation, not a map operation. This should likely be testing a map function or the variable name h is misleading for a map test.

#include "unity.h"

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 42 out of 42 changed files in this pull request and generated 5 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Typo in comment: 'ata' should be 'at a'. Should read: '/// Remove the key and value at a given key'

Suggested change

	/// Remove the key and value ata given key
	/// Remove the key and value at a given key

[Copilot]

Pull Request Overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 57 out of 57 changed files in this pull request and generated 4 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 68 out of 68 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 68 out of 68 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tests/test_memory.c:1

• [nitpick] Passing multiple NULL parameters makes the test intention unclear. Consider using descriptive variable names or comments to clarify which parameters are being tested as invalid.

#include "juno/macros.h"

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 68 out of 68 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

include/juno/module.h:1

• The variadic macro for failure operations could be dangerous if the failure code contains multiple statements that should be treated atomically. Consider wrapping __VA_ARGS__ in a do-while(0) block for safer macro expansion.

/*

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[robinonsay]

closing this MR since it's not ready