fix: telemetry UI's state handling#563
Open
doudou wants to merge 4 commits into
Open
Conversation
doudou
force-pushed
the
fix_telemetry_ui_state_handling
branch
2 times, most recently
from
2cf95f4 to
a03f758
Compare
doudou
changed the title
The current discovery code would do remote calls (good !) but also register the async objects (bad !) in separate threads. Move the second part to the main thread
The code would only call read_new and update the last known value with the return value unconditionally (that is, with nil if there was no updates). Use read_with_result to have proper flow information and propagate that information.
doudou
force-pushed
the
fix_telemetry_ui_state_handling
branch
from
a03f758 to
5175e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.