Skip to content

Drive CI job dispatch and doc status from repo_config - #377

Open
lykimq wants to merge 6 commits into
masterfrom
quyen@bot_general_pr5
Open

Drive CI job dispatch and doc status from repo_config#377
lykimq wants to merge 6 commits into
masterfrom
quyen@bot_general_pr5

Conversation

@lykimq

@lykimq lykimq commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  • Route bench jobs and Rocq-specific failure handling from repo_config.jobs (bench_job, use_rocq_job_status)
  • Replace hardcoded coq/coq Docker-manifest silencing with silence_docker_manifest_errors
  • Build doc artifact / GitLab status URLs from repo GitLab coordinates; gate on doc_artifact_jobs
  • Thread repo_config_table through the GitLab job webhook into job_action
  • Add helpers + Alcotest coverage for the new job config fields

@lykimq
lykimq force-pushed the quyen@bot_general_pr5 branch from 9c414c1 to 3513d56 Compare August 4, 2026 07:16
@lykimq
lykimq requested a review from Zimmi48 August 4, 2026 07:16
Comment thread coqbot-config.toml
# Use Rocq-specific failure summaries / allow-failure handling
use_rocq_job_status = true
# Successful jobs that get a GitHub status check linking to doc artifacts
silence_docker_manifest_errors = true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this line should have been inserted above the comment rather than below it.

Comment thread src/ci/documentation.ml
Comment on lines +62 to +78
match job_info.build_name with
| "doc:refman" ->
send
~fallback_artifacts:["_build/default/doc/refman-html/index.html"]
"doc/refman-html/index.html"
| "rocq-prover/rocq", "doc:ci-refman" ->
send_doc_url_job ~bot_info job_info "ci-refman"
"refman" "doc/refman-html/index.html"
| "doc:ci-refman" ->
send
~fallback_artifacts:["_build/default/doc/refman-html/index.html"]
"_build_ci/refman/refman-html/index.html"
| "rocq-prover/rocq", "doc:init" ->
send_doc_url_job ~bot_info job_info "corelib"
"_build/default/doc/corelib/html/index.html"
| ( "rocq-prover/rocq"
, ( "doc:stdlib" (* only after complete switch to Dune *)
| "doc:stdlib:dune" (* only before complete switch to Dune *) ) ) ->
send_doc_url_job ~bot_info job_info "stdlib"
"_build/default/doc/stdlib/html/index.html"
| "rocq-prover/rocq", "doc:ml-api:odoc" ->
send_doc_url_job ~bot_info job_info "ml-api"
"_build/default/_doc/_html/index.html"
"ci-refman" "_build_ci/refman/refman-html/index.html"
| "doc:init" ->
send "corelib" "_build/default/doc/corelib/html/index.html"
| "doc:stdlib" ->
send "stdlib" "_build/default/doc/stdlib/html/index.html"
| "doc:stdlib:dune" ->
send "stdlib" "_build/default/doc/stdlib/html/index.html"
| "doc:ml-api:odoc" ->
send "ml-api" "_build/default/_doc/_html/index.html"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some latter point, this could also become part of the config.

Comment thread src/config/repo_config.ml
if String.equal domain "gitlab.com" then owner ^ ".gitlab.io"
else if String.is_prefix domain ~prefix:"gitlab." then
owner ^ ".gitlabpages." ^ String.drop_prefix domain 7
else owner ^ ".gitlablpages." ^ domain

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else owner ^ ".gitlablpages." ^ domain
else owner ^ ".gitlabpages." ^ domain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants