Skip to content

[ci] Enable ASAN special build that does not halt #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ferdymercury wants to merge 3 commits into from
Closed

[ci] Enable ASAN special build that does not halt #19636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e39226
[cmake] clarify asan build option is only for gcc or clang
ferdymercury Aug 13, 2025
8138181
[core] do not interrupt build when an asan error is found
ferdymercury Aug 13, 2025
28463ed
[ci] enable asan in Ubu24 build
ferdymercury Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/root-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,9 @@ jobs:
- image: ubuntu22
overrides: ["imt=Off", "CMAKE_BUILD_TYPE=Debug"]
- image: ubuntu2404
overrides: ["CMAKE_BUILD_TYPE=Debug"]
is_special: true
property: ASAN
overrides: ["CMAKE_BUILD_TYPE=Debug", "asan=ON"]
- image: ubuntu2504
overrides: ["CMAKE_CXX_STANDARD=23"]
# Disable until binutils 2.45-5 is part of the distro, as it fixes the ".cfi_escape with op" warning.
Expand Down
2 changes: 1 addition & 1 deletion cmake/modules/RootBuildOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ option(minimal "Enable only required options by default" OFF)
option(rootbench "Build rootbench if rootbench exists in root or if it is a sibling directory." OFF)
option(roottest "Build roottest if roottest exists in root or if it is a sibling directory." OFF)
option(testing "Enable testing with CTest" OFF)
option(asan "Build ROOT with address sanitizer instrumentation" OFF)
option(asan "Build ROOT with address sanitizer instrumentation (only GCC or Clang)" OFF)

set(gcctoolchain "" CACHE PATH "Set path to GCC toolchain used to build llvm/clang")

Expand Down
3 changes: 2 additions & 1 deletion core/sanitizer/SanitizerSetup.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ const char* __asan_default_options() {
":detect_container_overflow=1"
":alloc_dealloc_mismatch=0"
DETECT_LEAKS
":verify_asan_link_order=0";
":verify_asan_link_order=0"
":halt_on_error=0";
}

/// Default options when leak sanitizer starts up in ROOT exectuables.
Expand Down
Loading