[ci] Add minimal asan build#22618
Conversation
Test Results2 601 tests 2 594 ✅ 9h 21m 44s ⏱️ For more details on these failures, see this check. Results for commit b7bfb1c. ♻️ This comment has been updated with latest results. |
|
this is a great initiative. To optimise, one could even turn off all other builds while in the PR with a specific commit, so that only asan can be tested, the necessary fixes added, and then all other builds re-added before merging |
ferdymercury
left a comment
ferdymercury
left a comment
There was a problem hiding this comment.
Thanks! Could you port the changes from https://github.com/root-project/root/pull/19636/changes into here?
The documentation fix for asan build option and portentially the Halton error flag to get s full overview at once
Thks!
| option(roottest "Build roottest (implies testing=ON)" OFF) | ||
| option(testing "Enable testing with CTest" OFF) | ||
| option(asan "Build ROOT with address sanitizer instrumentation" OFF) | ||
| option(asan "Build ROOT with address sanitizer instrumentation (only GCC is currently supported)" OFF) |
There was a problem hiding this comment.
IIRC I managed to enable ASAN build on Windows (TBC)
There was a problem hiding this comment.
Should I remove the change or do you want to verify if it still works?
There was a problem hiding this comment.
That is great!
I think we should exclude the tests flagged by ASAN to get this merged green. Then, we add the list of failing tests to an issue so that we remember to fix up. After the fix up, I think we should slowly add more components to the ASAN build.
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
LGTM!
Test failures should be triaged / tests excluded before merging.
silverweed
force-pushed
the
ci_asan
branch
2 times, most recently
from
4ec3351 to
b7bfb1c
Compare
Tracked in issue root-project#22632
6 participants
Using the alma10 image.
IMPORTANT: asan currently only works with gcc (or at least, that was the case on my machine).