[ntuple] Add schema profile visualizator backend supporting Speedscope#22641
Open
albfsg wants to merge 4 commits into
Open
[ntuple] Add schema profile visualizator backend supporting Speedscope#22641albfsg wants to merge 4 commits into
albfsg wants to merge 4 commits into
Conversation
albfsg
force-pushed
the
flame_visualizer_backend
branch
from
22e1cd4 to
42fcc76
Compare
Author
|
Images of how Speedscope renders the output of the method as a left-heavy view and a sandwich view: 
|
Author
|
Images of how Speedscope renders the output of the method for the test ntuple as a left-heavy view and a sandwich view: 
|
silverweed
reviewed
Jun 17, 2026
silverweed
left a comment
silverweed
left a comment
Contributor
There was a problem hiding this comment.
Thank you! This is already in a very good state, I mostly have minor comments about it.
| /// | ||
| /// \param[in] format The output format for the flamegraph specification (right now only supports Speedscope's JSON) | ||
| /// | ||
| void PrintFieldTreeAsFlamegraphSpecification(EFlamegraphSpecificationFormat format, |
Contributor
There was a problem hiding this comment.
I'm unsure whether to call it "Flamegraph", as it's more of a profile viewer...we might want to just name this method something like PrintSchemaAsProfile / PrintSchemaProfile.
@jblomer any suggestion?
Contributor
|
Replaces #4634 |
albfsg
changed the title
silverweed
reviewed
Jun 18, 2026
| kUncompressedSize | ||
| }; | ||
|
|
||
| enum class ESchemaProfileFormat { |
Contributor
There was a problem hiding this comment.
Thinking about it, this enum should probably be defined inside RNTupleInspector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes:
This PR adds
void PrintFieldTreeAsFlamegraphSpecification(EFlamegraphSpecificationFormat format, std::ostream &output = std::cout) const;method to theRNTupleInspectorclass.It also adds a trivial unit test to the
ntuple_inspector.cxxfile which locally works.Checklist:
ntuple_inspectorfile tests.