[build] Improve finding Spark-compatible Java version#22643
Open
vepadulano wants to merge 1 commit into
Open
Conversation
Different Spark versions support different versions of Java. The latest versions of Spark support current LTS Java versions 17 and 21. In any case, there is no Spark version that supports a Java version greater than 21. Thus, we should check in CMake that the environment-installed Java version is in a reasonable range. Since the CMake FindJava module does not support version ranges, we introduce an extra check with an error in case a too recent version of Java is detected. This would help fail early on CI nodes where an incompatible Java version is installed.
vepadulano
force-pushed
the
build-check-spark-compatible-java-version
branch
from
3be7728 to
c202c63
Compare
guitargeek
approved these changes
Jun 17, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Nice! This has confused me in the past, so I appreciate the fix.
Test Results 22 files 22 suites 3d 13h 54m 46s ⏱️ For more details on these failures, see this check. Results for commit c202c63. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different Spark versions support different versions of Java. The latest versions of Spark support current LTS Java versions 17 and 21. In any case, there is no Spark version that supports a Java version greater than 21. Thus, we should check in CMake that the environment-installed Java version is in a reasonable range. Since the CMake FindJava module does not support version ranges, we introduce an extra check with an error in case a too recent version of Java is detected.
This would help fail early on CI nodes where an incompatible Java version is installed.