Add GH16805 RNTupleProcessor regression test#22644
Conversation
matildamarjamaki
requested review from
bellenot,
jblomer and
silverweed
as code owners
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you @matildamarjamaki for this contribution, I believe it's a good addition! I left a couple of minor remarks but the changes look already good.
Test Results 21 files 21 suites 3d 12h 54m 10s ⏱️ For more details on these failures, see this check. Results for commit f54dc5f. |
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments! Just two last minor suggestions from my side
| if(pyroot) | ||
| ROOT_ADD_PYUNITTEST(ntuple_py_basics ntuple_basics.py) | ||
| ROOT_ADD_PYUNITTEST(ntuple_py_model ntuple_model.py) | ||
|
|
There was a problem hiding this comment.
This extra line is not necessary here, please remove it.
| " +-----------------------------+\n"; | ||
| EXPECT_EQ(exp2, os2.str()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Here it would be good to reference the original context for the TTree equivalent test. Maybe add a comment just before the class name
This test is a translation using RNTupleProcessor of the test introduced by https://github.com/root-project/root/pull/19322, to ensure that the TTree friendship mechanism works equivalently with the RNTuple join mechanism.
enirolf
left a comment
enirolf
left a comment
There was a problem hiding this comment.
Very nice! I have one minor comment from my side, once that's addressed from my side it's good to go.
| "gh16805_rntuple_friend_0.root", | ||
| "gh16805_rntuple_friend_1.root", | ||
| "gh16805_rntuple_friend_2.root" |
There was a problem hiding this comment.
To ensure consistency between terms, I would be in favor to use only "join" when talking about RNTuple, instead of "friends".
4 participants
Summary
Adds a regression test for the GH16805 RNTupleProcessor use case.
The test creates several RNTuples corresponding to the original TTree setup ("stepzero", "stepone" and "topLevelFriend"), composes them using "RNTupleProcessor::CreateChain" and "RNTupleProcessor::CreateJoin" and validates the resulting values with "EXPECT_EQ".
The goal is to provide a simple regression test covering a TTree-friends-like workflow implemented with RNTupleProcessor.