[ntuple] Introduce feature flag 0 and some fixes/improvements related to it#22655
Open
silverweed wants to merge 6 commits into
Open
[ntuple] Introduce feature flag 0 and some fixes/improvements related to it#22655silverweed wants to merge 6 commits into
silverweed wants to merge 6 commits into
Conversation
Also fix the type of result
In code, this feature is represented by an update in the logic of RClusterDescriptorBuilder::AddExtendedColumnRanges(), which now handles properly the case where a column is added in a later cluster and therefore cannot rely on the (NEntries * NRepetitions) calculation, so it instead copies its FirstElementIndex and NElements from the 0th representation (which is guaranteed to have valid numbers for them).
This is necessary to support multiple representations that use the same column type but different metadata (e.g. different bit width on Real32Trunc columns)
6 tasks
Test Results 22 files 22 suites 3d 14h 42m 19s ⏱️ Results for commit 46dbe4c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
contains the part of #22017 that needs to be backported to 6.40 and 6.36, most notably our first feature flag.
This PR is not the backport, it's what will land in master.
Note that neither the backport nor this PR introduce support for writing the new feature flag, only for reading. Writing support will not be backported.
See the individual commits for more context.
NOTE: this PR bumps the binary format to version 1.1.0.0. In the backport, the binary format will be bumped to 1.0.2.1, as it's a backported patch of the spec.
Checklist: