Game versions become the fourth derived tag group - #134
Merged
Conversation
…the card Both rows now say outright what the adapter means for them: TSPML supplies the PML runtime itself, so neither is required — install only if a mod asks by name (nothing in the catalog does). The pmlapi summary also dropped a stale clause claiming mixins 'cannot carry across'; token-anchored ones have since #133.
Owner: "also add version numbers to the tag". Fourth application of the derivation rule (format, persons, no-build prose, versions): everything a card states about itself is computed from the row's own fields. The chip is the versions the row COVERS, not the gameVersions list: computed with buildsForGameVersion against a universe (every release version in the catalog + the launcher default, newest first). Chipping the literal range string would have made the 0.6.2 filter falsely drop poly-to-track, the one native mod — pinned by unit test and smoke:registry leg 2d (chip narrows to exactly the eight covering rows, range entry among them; the inverse of the thirteen-warned assertion, one predicate). Prereleases are excluded from the universe — a beta chip answers nobody's filter question; the detail facts row still shows the full list. The filter and the chips agree by construction: searchRegistry derives its own universe from the entries in scope, the grid passes the tab's, the detail page the registry's. Monospace (.tag-version) is the only visual signature. Portal 722 -> 728 tests (registry.test.ts 80 -> 86); repo-wide 1,341 green; smoke typecheck after the last script edit; smoke:registry PASS with the new leg; screenshot review done (four labelled rows: loader/category/version/people).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Owner: "also add version numbers to the tag" — plus the PML Core/PML API summary fix from the question that preceded it (both commits ride this PR).
Version tags
Fourth application of the derivation rule (format → persons → no-build prose → versions): every chip a card states about itself is computed from the row's own fields, never hand-written into
tags.gameVersionslist — computed withbuildsForGameVersionagainst a universe (every release version in the catalog + the launcher default, newest first). Chipping the literal range string would have made the0.6.2filter falsely drop poly-to-track, the one native mod; expanding to covered versions keeps it, pinned by unit test ANDsmoke:registryleg 2d (chip narrows to exactly the eight covering rows, range entry among them — the inverse of the thirteen-warned assertion, one predicate).searchRegistryderives its own universe from the entries in scope, the grid passes the tab's, the detail page the registry's..tag-version) is the only visual signature; the coarse-pointer tap-target rule updated for the card-span variant.PML Core / PML API summaries
Both rows now answer "do I need this?" on the card: not needed under TSPML — the adapter supplies the PML runtime; nothing in the catalog depends on either. The pmlapi summary also dropped a stale "mixins cannot carry across" clause (#133 made it untrue).
Proof
tscclean; smoke typecheck clean and run after the last script edit.smoke:registryPASS with leg 2d; screenshot review done (four labelled rows: loader / category / version / people, versions newest-first).Docs (same merge)
docs/project/progress.mdnew section,docs/concepts/pml-compatibility.mdcatalog section, README bullet + count 1,341.