PML range ops are INCLUSIVE; a stalled import body can no longer wedge the Add form - #137
Merged
Merged
Conversation
…o longer wedge the Add form
The 20-mod sweep ("test every pml mod") found two real bugs and one open
defect.
INCLUSIVE RANGES: PolyTypes.js's own doc comments say "Replace code between
2 given tokens. Inclusive." — the anchors are replaced along with the span,
and every real mod's func only makes sense that way. Ours kept the anchors,
so carswitcher's twin splice on "models/car.glb" (func:
window.localStorage.MyCar || "models/car.glb") produced two adjacent
expressions — a syntax error the re-parse gate turned into base-failed. The
first full-library attempt died exactly there. With the fix the same mod set
boots planStatus: applied and the car-model twin is 1/3 (the other two
anchors genuinely match 0 on main; one targets 604.bundle.js).
BODY-READ TIMEOUT: fetchText cleared its 20s abort timer when the response
HEADERS arrived, so a body that never finished streaming hung the import
promise forever — no error, no row, the Add form silently wedged on one bad
CDN connection (observed live). The timer now covers headers through body;
a stalled stream fails as "timed out".
THE OPEN DEFECT (documented in progress.md, not fixed here): sequential
installs stall from the fifth — sometimes writing storage without updating
the library count, sometimes never settling. Solo installs of the same mods
work (ghosttoggle's real id is mrgtmod — two harness generations died
waiting for catalog slugs that never exist as installed ids). Suspect: the
page's import → updateUserMods → refreshRunningSet reload-chain interplay.
Also noted: xenon installs but never loads.
Portal 735 -> 740 tests (inclusive expectations, carswitcher's
distinct-anchor shape, the fetchText body-timeout suite); repo-wide 1,352
green; smoke:pml PASS; smoke typecheck after the last script edit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(portal): PML range ops are INCLUSIVE; a stalled import body can no longer wedge the Add form
The 20-mod sweep ("test every pml mod") found two real bugs and one open
defect.
INCLUSIVE RANGES: PolyTypes.js's own doc comments say "Replace code between
2 given tokens. Inclusive." — the anchors are replaced along with the span,
and every real mod's func only makes sense that way. Ours kept the anchors,
so carswitcher's twin splice on "models/car.glb" (func:
window.localStorage.MyCar || "models/car.glb") produced two adjacent
expressions — a syntax error the re-parse gate turned into base-failed. The
first full-library attempt died exactly there. With the fix the same mod set
boots planStatus: applied and the car-model twin is 1/3 (the other two
anchors genuinely match 0 on main; one targets 604.bundle.js).
BODY-READ TIMEOUT: fetchText cleared its 20s abort timer when the response
HEADERS arrived, so a body that never finished streaming hung the import
promise forever — no error, no row, the Add form silently wedged on one bad
CDN connection (observed live). The timer now covers headers through body;
a stalled stream fails as "timed out".
THE OPEN DEFECT (documented in progress.md, not fixed here): sequential
installs stall from the fifth — sometimes writing storage without updating
the library count, sometimes never settling. Solo installs of the same mods
work (ghosttoggle's real id is mrgtmod — two harness generations died
waiting for catalog slugs that never exist as installed ids). Suspect: the
page's import → updateUserMods → refreshRunningSet reload-chain interplay.
Also noted: xenon installs but never loads.
Portal 735 -> 740 tests (inclusive expectations, carswitcher's
distinct-anchor shape, the fetchText body-timeout suite); repo-wide 1,352
green; smoke:pml PASS; smoke typecheck after the last script edit.